Skip to content

RemoteSettings: exclude Loop APNS from Team ID mismatch check #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

RemoteSettings: exclude Loop APNS from Team ID mismatch check #473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de106ff
RemoteSettings: exclude Loop APNS from Team ID mismatch check
bjorkert Oct 12, 2025
58ee5e1
Clean up comments
bjorkert Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions LoopFollow/Remote/Settings/RemoteSettingsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,15 @@ class RemoteSettingsViewModel: ObservableObject {

// Determine if a comparison is needed and perform it.
switch remoteType {
case .loopAPNS, .trc:
// For both Loop and TRC, the target Team ID is in the same storage location.
case .trc:
// If the target ID is empty, there's nothing to compare.
guard !targetTeamId.isEmpty else {
return false
}
// Return true if the IDs are different.
return loopFollowTeamID != targetTeamId

case .none, .nightscout:
case .loopAPNS, .none, .nightscout:
// For other remote types, this check is not applicable.
return false
}
Expand Down