Create new tokens setting + bug fix

[mxposed]

createTokens setting allows the creation of new token on enter.

The bug fixed was that if you have set selected_dropdown_item and then type another character and then quickly press enter you would get an error pointing to the add_token function with item being undefined.

[anuragphadke19]

Thanks a lot for this added functionality. +1 for pulling this into the original.

[johnlcox]

It looks like the createTokens setting only allows adding tokens when no autocomplete results are found. However, if someone doesn't like any of the autocomplete results and would like to add a new token instead it will force them to select one of the available options.

[mxposed]

johnicox: yes, this is intended. Otherwise it would be ambiguous what token the user wants. So the user should dismiss the autocomplete with escape and then press enter or comma to create the token

[ozzyogkush]

I hope this gets pulled in, seems to be working great so far. Thanks for fixing that add_token bug, that was very frustrating.

[duro]

Let's get this baby pulled in...I think many people need this feature.

[micred]

+1

[ches]

#219 takes a different approach to the ambiguity matter -- it displays a "what-you've-typed (Create new token)" entry in the menu so it can be chosen. The text is configurable. The callback hook that that pull req includes is a nice addition as well.

Though there is still room for improvement (would be nice if pressing comma was a shortcut to selecting the "create new" entry, for instance), personally I think that approach is more intuitive for the user than what @mxposed proposed above. Ideally both could be supported, so that if I do happen to dismiss the menu but then press comma, that should also create the token (if what has been typed so far isn't a duplicate).