-
-
Notifications
You must be signed in to change notification settings - Fork 4
Closed
Description
Currently the digest command is hard-coded to work with the EmailChannel
. And the EmailChannel
is hardcoded to use Django's send_mail
. This makes it really hard to make a new channel that would send email via Celery for example.
- It would be great if the actual sending of the email within
EmailChannel
could be moved to a class method, which could be overridden by a subclass, likeCeleryEmailChannel
. This method would receive all necessary data to send the email, like recipient, subject, html and plain text, etc. - The digest sending functionality should work for ANY registered channels which work with frequencies.
- We should probably rename
send_email_now
tosend_now
andsend_digest_emails
tosend_digest
. Because we might have channels, that use digest frequencies, that have nothing to do with email.
Metadata
Metadata
Assignees
Labels
No labels