Skip to content

Pre Release Changes #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Pre Release Changes #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
468b2fc
fix: Switch UGC casing on feedback method
Sep 12, 2024
97c44b1
fix: Hide pre-elease methods
Sep 12, 2024
a029578
fix: Disable functional tests (not working)
Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/run-tests-and-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ on:

jobs:
functional-tests:
name: Functional tests with config ${{ matrix.unityVersion }}-${{ matrix.testMode }}-${{ matrix.jsonLibrary }}
name: DISABLED Functional tests with config ${{ matrix.unityVersion }}-${{ matrix.testMode }}-${{ matrix.jsonLibrary }}
runs-on: ubuntu-latest
#Disable for now, will be replaced by "Integraton tests"
if: ${{ true == false }}
timeout-minutes: 20
strategy:
fail-fast: false
Expand Down
10 changes: 5 additions & 5 deletions Runtime/Game/LootLockerSDKManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5403,7 +5403,7 @@ public static void ListGameFeedbackCategories(Action<ListLootLockerFeedbackCateg
/// Returns a list of categories to be used for giving feedback about a certain ugc asset.
/// </summary>
/// <param name="onComplete">onComplete Action for handling the response of type ListLootLockerFeedbackCategoryResponse</param>
public static void ListUgcFeedbackCategories(Action<ListLootLockerFeedbackCategoryResponse> onComplete)
public static void ListUGCFeedbackCategories(Action<ListLootLockerFeedbackCategoryResponse> onComplete)
{
ListFeedbackCategories(LootLockerFeedbackTypes.ugc, onComplete);
}
Expand Down Expand Up @@ -5769,8 +5769,8 @@ public static void GetEntitlement(string entitlementId, Action<LootLockerSingleE

#endregion

#region Metadata

#region Metadata
#if LOOTLOCKER_PRE_RELEASE
/// <summary>
/// List Metadata for the specified source with default pagination
/// </summary>
Expand Down Expand Up @@ -5854,8 +5854,8 @@ public static void GetMetadata(LootLockerMetadataSources Source, string SourceID
});
});
}

#endregion
#endif
#endregion

#region Misc

Expand Down
Loading