Skip to content

Reject symbol-keyed map objects in wasm conversion #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zxch3n merged 2 commits into from
Nov 11, 2025
Merged

Reject symbol-keyed map objects in wasm conversion #855

zxch3n merged 2 commits into from
Nov 11, 2025

Conversation

@zxch3n
Copy link
Member

@zxch3n zxch3n commented Nov 11, 2025

Summary

  • reject JS objects that contain symbol keys when converting to Loro values so we surface an error instead of panicking
  • add a regression test proving LoroMap.set throws when given an object with symbol-keyed properties

Testing

  • cargo check -p loro-wasm
  • pnpm release-wasm (fails: missing deno in the environment)

Codex Task

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025 •
edited
Loading

WASM Size Report

  • Original size: 3178.58 KB
  • Gzipped size: 1005.31 KB
  • Brotli size: 697.59 KB

@zxch3n zxch3n merged commit 9e0a613 into main Nov 11, 2025
1 check passed
This was referenced Nov 11, 2025
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zxch3n