Skip to content

exact_mc_synthesis resolved z3 dependency #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

exact_mc_synthesis resolved z3 dependency #360

merged 1 commit into from
Jun 11, 2020

Conversation

@hriener
Copy link
Member

@hriener hriener commented Jun 8, 2020

Exclude experiment exact_mc_synthesos if Z3 is not available.

@hriener hriener requested a review from msoeken June 8, 2020 11:43
@hriener
Copy link
Member Author

hriener commented Jun 8, 2020 •
edited
Loading

Another option would be to exclude the experiment already in the CMakeLists if z3 is not available and emit a warning then. It would maybe save a user, who wants to run this experiment, early on from some disappointment.

@coveralls
Copy link

coveralls commented Jun 8, 2020

Pull Request Test Coverage Report for Build 128538168

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.857%
Totals Coverage Status
Change from base Build 124876876: 0.0%
Covered Lines: 8722
Relevant Lines: 10922
💛 - Coveralls

@hriener hriener merged commit d88fdb7 into master Jun 11, 2020
@hriener hriener deleted the common branch June 11, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msoeken msoeken Awaiting requested review from msoeken

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hriener @coveralls