Skip to content

Conversation

@lee30sonia
Copy link
Member

This PR:

  • Adds an interface generate_pattern to generate multiple different PI patterns for a node to be a certain value in circuit_validator. This will be used in another PR for pattern_generation. I only implement this method for validating with a constant value because I only use it here. But if generating multiple CEXs in other types of validation is needed in other applications, it is also possible to be implemented in the future.
  • Fixes a bug when providing the constant node as the first argument of validate. (Actually just removing unnecessary assertions.)

@coveralls
Copy link

coveralls commented Jul 1, 2020

Pull Request Test Coverage Report for Build 154580216

  • 27 of 29 (93.1%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 80.16%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/mockturtle/algorithms/circuit_validator.hpp 27 29 93.1%
Totals Coverage Status
Change from base Build 153854969: 0.03%
Covered Lines: 8921
Relevant Lines: 11129

💛 - Coveralls

@hriener hriener merged commit b4129df into master Jul 2, 2020
@hriener hriener deleted the lee30sonia/validator branch July 2, 2020 07:26
@hriener
Copy link
Member

hriener commented Jul 2, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants