Use parallel_hashmap instead of sparsepp. #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The author of sparsepp already said that this library is deprecated and the use of 'parallel_hashmap' is preferred. The only 'weirdness' with this is in the serializer/deserializer. I couldn't find a way to make it work with 'streams', only with file streams using the binary archive methods from 'parallel_hashmap'.
Pull Request Test Coverage Report for Build 354746003
💛 - Coveralls |
Member
|
This PR seems to be quite useful. I run some experiments and it seems that the performance of our experiments improves by 10 - 30%. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author of sparsepp already said that the library is deprecated and
the use of 'parallel_hashmap' is preferred.
The only 'weirdness' with this is in the serializer/deserializer.
I couldn't find a way to make it work with 'streams', only with file
streams using the binary archive methods from 'parallel_hashmap'.
Closes #339