Skip to content

Conversation

@hriener
Copy link
Member

@hriener hriener commented Nov 15, 2020

This PR makes minor changes to the logic of take_out_node, replace_in_outputs, and substitute_node:

  • Avoid fanout-size updates when deleting a node, which has already been deleted before.
  • Avoid updating primary outputs if the update propagates from a dead node.
  • Avoid update propagation from dead nodes in the hash.

A new test case ensures that take_out_node can be invoked twice on the same node without recursively affecting its fanins.

@coveralls
Copy link

coveralls commented Nov 15, 2020

Pull Request Test Coverage Report for Build 364589351

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 80.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/mockturtle/networks/aig.hpp 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
include/mockturtle/algorithms/dsd_decomposition.hpp 3 87.5%
Totals Coverage Status
Change from base Build 359476365: -0.03%
Covered Lines: 10309
Relevant Lines: 12848

💛 - Coveralls

@hriener hriener merged commit 377d133 into master Nov 15, 2020
@hriener hriener deleted the bugfix_november_15 branch November 15, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants