Skip to content

Bugfix for special case in substitute_node #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2020
Merged

Bugfix for special case in substitute_node #404

merged 2 commits into from
Nov 30, 2020

Conversation

@hriener
Copy link
Member

@hriener hriener commented Nov 30, 2020 •
edited
Loading

This PR provides a quick-fix for an issue triggered by a special case in the implementation of substitute_node:

  • A failing test case documents the issue.
  • replace_in_node is modified to avoid returning a node equal to the old_node that will be deleted later.

@hriener hriener requested a review from msoeken November 30, 2020 21:40
@coveralls
Copy link

coveralls commented Nov 30, 2020

Pull Request Test Coverage Report for Build 392528081

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.255%
Totals Coverage Status
Change from base Build 373950906: 0.0%
Covered Lines: 10308
Relevant Lines: 12844
💛 - Coveralls

@hriener hriener merged commit acf3d01 into master Nov 30, 2020
@hriener hriener deleted the substitute_bugfix branch November 30, 2020 21:59
@lee30sonia lee30sonia mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msoeken msoeken Awaiting requested review from msoeken

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hriener @coveralls