-
Notifications
You must be signed in to change notification settings - Fork 156
Add dedicated operator== overload between signal and pointer_type #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Besides, it would be better to add another item(s) into |
Pull Request Test Coverage Report for Build 599328370
💛 - Coveralls |
|
Thank you for the PR! As you have noticed, we do not support C++20 yet. However, I appreciate the changes to prepare Do you have a suggestion for the workflow update? What's the compiler that you would like to target? |
|
@hriener I believe GCC >=10.2.0 would do the job (I'm personally using 10.2.0 locally.) |
|
Agreed. I'm happy to merge the workflow/CMake update if you would like to commit the changes to the branch (assuming that the required changes are not too invasive). |
|
I'm not very familiar with github workflows so maybe you could merge the PR first and the modify |
|
I like your idea of adding a c++20 compiler first to verify that the changes are indeed required and correct. Also, updating the workflows should be not too complicated; let me see if I can get it done by the end of the week. |
|
Thanks! |
C++20 has significant modifications on the overloads of
operator==. See the following demo: https://godbolt.org/z/dTvncjIn order to ease the transition to C++20 some day, it'd be better to stop relying on the C++17's
operator==behavior; otherwise, the following error would occur when compiling the existing code base using C++20: