-
Notifications
You must be signed in to change notification settings - Fork 156
XAG resynthesis engine (re-implementation of ABC's k-resub) #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- missing support for XOR - missing tests for recursive decomposition case - missing documentation - missing parameter for max_binate_divisors - interfacing issue: an redundant PI in index_list (ABC format) - TODO: compare with abcresub
- missing support for XOR - missing tests for recursive decomposition case - missing documentation - interfacing issue: an redundant PI in index_list (ABC format) - TODO: add API in circuit_validator using index_list to avoid interfacing with imaginary_circuit
Finished comparison with ABC: Whenever abcresub finds a solution, so does xag_resyn. Runtimes are also similar. - missing support for XOR - missing documentation - interfacing issue: needs a redundant PI in index_list (ABC format) - TODO: add API in circuit_validator using index_list to avoid interfacing with imaginary_circuit
Pull Request Test Coverage Report for Build 618381831
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a mockturtle-native re-implementation of the k-resub engine in ABC (called
xag_resyn_enginein parallel tomig_resyn_engine). Completeness with respect toabcresubis verified. When applied insim_resub, runtime is usually dominated by SAT-solving (even with pre-stored CEXs), and the overall runtime is similar to ABC.Also,
circuit_validator::gateis replaced byindex_listfor more efficient interfacing.mig_resyn_engines.hppandxag_resyn_engines.hppare put together in the pathalgorithms/resyn_engines, and the public interface for all these engines are unified.ResubFninsimulation_based_resub_engineare modified.sim_aig_resub(enumeration-based resub functor forsim_resub) is removed.Missing features that will be implemented in future PRs:
abcresublibrary can be removed frommockturtle.