Skip to content

Conversation

@hriener
Copy link
Member

@hriener hriener commented Apr 23, 2021

This PR updates window_rewriting. The implementation becomes more robust, different strategies for updating level information are introduced.

Summary:

  • Different strategies to update node level after window substitution (dont_update, eager, precise, recompute)
  • New debugging utils: count_nodes_with_dead_fanins, count_reachable_dead_nodes_from_node
  • Support for auto-resizing levels in levelized_expand_towards_tfo if network depth has not been update

@coveralls
Copy link

coveralls commented Apr 23, 2021

Pull Request Test Coverage Report for Build 778424576

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 81.316%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/mockturtle/utils/window_utils.hpp 4 7 57.14%
Totals Coverage Status
Change from base Build 777669409: -0.01%
Covered Lines: 10876
Relevant Lines: 13375

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Merging #449 (343ccfb) into master (72906aa) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   81.02%   80.97%   -0.06%     
==========================================
  Files         118      118              
  Lines       12751    12780      +29     
==========================================
+ Hits        10331    10348      +17     
- Misses       2420     2432      +12     
Impacted Files Coverage Δ
include/mockturtle/utils/window_utils.hpp 93.57% <57.14%> (-0.82%) ⬇️
...nclude/mockturtle/algorithms/dsd_decomposition.hpp 87.14% <0.00%> (-4.29%) ⬇️
include/mockturtle/views/aqfp_view.hpp 78.76% <0.00%> (-2.96%) ⬇️
include/mockturtle/views/depth_view.hpp 97.26% <0.00%> (+0.11%) ⬆️
include/mockturtle/networks/klut.hpp 92.01% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72906aa...343ccfb. Read the comment docs.

@hriener hriener merged commit 75178f9 into master Apr 23, 2021
@hriener hriener deleted the window_rewriting branch April 23, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants