Skip to content

Conversation

@marcelwa
Copy link
Contributor

This PR builds upon #437 by consistently linking all libraries as SYSTEM because compiler warnings generated in third-party code are still propagated to including projects.

@codecov-commenter
Copy link

Codecov Report

Merging #469 (fadd7b9) into master (75380ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files         134      134           
  Lines       15230    15230           
=======================================
  Hits        12734    12734           
  Misses       2496     2496           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75380ce...fadd7b9. Read the comment docs.

@hriener hriener merged commit ae52625 into lsils:master May 18, 2021
@hriener
Copy link
Member

hriener commented May 18, 2021

Thanks!

@marcelwa marcelwa deleted the consistency_cmake_fix branch May 19, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants