feat: add fromDate and fromTimestamp factory methods to DateTime
#654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds two new factory methods to the DateTime class for creating instances from JavaScript's native Date objects and Unix timestamps. The methods (fromDate and fromTimestamp) complement the existing factory methods (fromPlain, fromString, etc.) and provide convenient interoperability with standard JavaScript date handling.
Key changes:
- Added
DateTime.fromDate()static method to create UTC DateTime from JavaScript Date objects - Added
DateTime.fromTimestamp()static method to create UTC DateTime from Unix timestamps in milliseconds - Added comprehensive test suites for both new factory methods including round-trip conversion tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/datetime.ts | Implements fromDate and fromTimestamp factory methods with proper JSDoc documentation; fromTimestamp delegates to fromDate for implementation |
| tests/unit/datetime.spec.ts | Adds test suites for both factory methods with parameterized tests and round-trip conversion validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.