DM-41730: Exception logs don't have metadata #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-41730
branch
2 times, most recently
from
8d98cb7 to
b028e6e
Compare
hsinfang
approved these changes
Dec 6, 2023
What could be done to make the code clearer? |
Exceptions now contain a logging_context member containing the log context that would have been applied at the point where the exception was first raised.
Including the exact signature makes it possible to interpret log record factory arguments directly.
kfindeisen
force-pushed
the
tickets/DM-41730
branch
from
b028e6e to
155c186
Compare
|
Not sure because things are clearer with the python |
This ensures that exceptions caught by high-level handlers (such as activator.py:server_error) are logged with any context known at the point where they were raised. This solution also works for logger calls that are themseslves inside context blocks.
kfindeisen
force-pushed
the
tickets/DM-41730
branch
from
155c186 to
2916e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments
RecordFactoryContextAdapterto log exceptions with the context in which the exception was raised, not the one in which it was caught.