DM-42038: Pipeline execution breaks on dimension version mismatch #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, a newly created repo uses the latest managers. However, if the central repo is using an older version of the dimensions-config manager than the local repo, then pipeline execution will fail with a version mismatch on DimensionUniverse. Synchronizing the dimensions at local repo construction time should mitigate the problem. (We may need to forcibly reboot pods during a central repo version migration, but that's still better than the current situation.)
kfindeisen
force-pushed
the
tickets/DM-42038
branch
from
ea418b7 to
5cfd8c9
Compare
timj
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces local repos to be created with whatever dimension config the central repo is currently using. This will prevent version mismatches from causing pipeline failures.
The downside of this arrangement is that, when the central repo is upgraded, we will need to make sure to reboot all our pods so that they continue to have a matching local repo. I'm not sure how to ensure that operationally.