DM-42071: Investigate HSC visit=19710 failure in dev test #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validity range uses TAI of observation start time, and the middleware interface uses private_sndStamp to obtain calibration data. Using day_obs as this timestamp is too coarse and can lead to picking the wrong calibration data in the edge case.
hsinfang
force-pushed
the
tickets/DM-42071
branch
from
f20830b to
33f2a85
Compare
ktlim
approved these changes
Dec 12, 2023
This reverts commit 73ed2bd "Add day_obs_to_unix_utc to tester utils." as the utility is no longer used.
hsinfang
force-pushed
the
tickets/DM-42071
branch
from
47c21c8 to
90ba05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.