Skip to content

Conversation

kfindeisen
Copy link
Member

This PR creates a script that can reproducibly upload raws from ap_verify_ci_cosmos_pdr2. It assumes that gsutil is already installed and configured.

@kfindeisen kfindeisen requested a review from parejkoj March 11, 2022 22:35
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it prompt_prototype_upload_raws.sh? I'd like to move away from "proto" if we can.

Or should we call it prompt_prototype_upload_ci_cosmos_pdr2.sh, to make it very explicit where it's coming from?

@kfindeisen
Copy link
Member Author

@parejkoj is this better?

@parejkoj
Copy link
Contributor

Thanks @kfindeisen . My only remaining question is whether we should name the script something related to the input data, e.g. prompt_prototype_upload_ci_cosmos_pdr2.sh?

@kfindeisen
Copy link
Member Author

I'd rather not. We might end up changing the backing dataset in-place, or we might upload multiple datasets from the same script.

@kfindeisen kfindeisen merged commit 231d5b8 into main Mar 12, 2022
@kfindeisen kfindeisen deleted the tickets/DM-34031 branch March 12, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants