DM-42726: Implement upload.py LSSTComCamSim for dev test #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-42726
branch
7 times, most recently
from
ec62316 to
41480d4
Compare
kfindeisen
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
I guess I'd worry a little about whether any variations in make_hsc_rc2_export and make_template_export were captured, but great idea!
There was a problem hiding this comment.
Honestly I'm a little worried about that too. This probably should have been done before DM-41241 and we could have felt more reassured.
| class Instrument: | ||
| n_snaps: int | ||
| n_detectors: int | ||
| sal_index: int = 0 |
There was a problem hiding this comment.
Good idea, given that (for better or worse) we're already assuming this in fan-out service.
Comment on lines
+161
to
+167
| raw_pool : mapping [`str`, mapping [`int`, mapping [`activator.FannedOutVisit`, `s3.ObjectSummary`]]] | ||
| Available raws as a mapping from group IDs to a mapping of snap ID. | ||
| The value of the innermost mapping is the observation metadata for | ||
| each detector, and a Blob representing the image taken in that | ||
| detector-snap. |
There was a problem hiding this comment.
We really ought to get a proper class for this! 😂 Maybe I'll find an opportunity...
|
Oh, one question: does this PR make #132 obsolete? |
|
Yes. #132 will be discarded. |
hsinfang
force-pushed
the
tickets/DM-42726
branch
3 times, most recently
from
c9e5168 to
0fb3f70
Compare
The extra fixup for HSC-RC2 isn't necessary and they can just be exported/imported.
Instead of hard-coding the selection in the script, move them to a yaml file so the script can be used for other exports more easily.
There were data-specific scripts for making the export yaml. They can now be different config files but used with one same generic script.
This exports an early version of the simulated data from /repo/ops-rehearsal-3-prep to prompt-processing's dev central repo.
Previuosly only the single-detector scenario, i.e. LATISS, was considered for LSST cameras. By using _add_to_raw_pool, multiple detectors per LSST exposure are supported in the upload test for other LSST cameras.
Currently images coming from ComCam DAQ has null FILTBAND. The camera team plans to fix it. For our simulated nextVisit messages we need something that is not null. Using FILTER is the next best thing.
hsinfang
force-pushed
the
tickets/DM-42726
branch
from
0fb3f70 to
13470fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.