DM-34123: Use hashable Visit in upload.py #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
force-pushed
the
tickets/DM-34123
branch
3 times, most recently
from
485936c to
e26c5eb
Compare
ebellm
force-pushed
the
tickets/DM-34123
branch
from
e26c5eb to
c35e0ab
Compare
ktlim
approved these changes
Mar 18, 2022
python/tester/upload.py
Outdated
| import re | ||
| import sys | ||
| import time | ||
| from visit import Visit |
There was a problem hiding this comment.
Maybe call this VisitMessage to be more clear?
ebellm
force-pushed
the
tickets/DM-34123
branch
from
281fe98 to
91fd6c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.