Skip to content

DM-44189: Remove ccdVisitId from Prompt Processing #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2024
Merged

DM-44189: Remove ccdVisitId from Prompt Processing #160

merged 2 commits into from
May 10, 2024

Conversation

kfindeisen
Copy link
Member

This PR uses Apdb.containsVisitDetector for error handling in pipeline execution, replacing the old dimension packer-based hack.

@kfindeisen
Migrate from ApdbSql.containsCcdVisit to Apdb.containsVisitDetector.
f0c2435 
This eliminates the need for creating a dimension packer in Prompt
Processing, or attaching dimension records when identifying the
visit ID.
@kfindeisen kfindeisen added the breaking change The next release with this PR must be a major version label May 9, 2024
@kfindeisen
Copy link
Member Author

kfindeisen commented May 9, 2024 •
edited
Loading

Breaking change because this change requires d_2024_05_07 or later, which introduces other incompatibilities.

parejkoj
parejkoj approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm a little bit surprised that this is the only place that needs a change, but I guess that's a sign of a well designed system!

@kfindeisen
Add abridged pipelines for HSC.
56017d1 
These pipelines are not needed in normal testing, but are useful when
you specifically want a faster pipeline or want to test something that
happens in early tasks.
@kfindeisen kfindeisen merged commit 1bacfe7 into main May 10, 2024
@kfindeisen kfindeisen deleted the tickets/DM-44189 branch May 10, 2024 01:00
@kfindeisen kfindeisen restored the tickets/DM-44189 branch May 10, 2024 01:11
@kfindeisen kfindeisen mentioned this pull request May 10, 2024
Merged
@kfindeisen kfindeisen deleted the tickets/DM-44189 branch May 10, 2024 19:19
@kfindeisen kfindeisen mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees

No one assigned

Labels

breaking change The next release with this PR must be a major version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kfindeisen @parejkoj