DM-34132: Use shared visit.py with pure python types #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
force-pushed
the
tickets/DM-34132
branch
from
45c96b4 to
9fed6ea
Compare
ebellm
changed the title
kfindeisen
requested changes
Mar 21, 2022
Comment on lines
+13
to
+17
| ra: float | ||
| dec: float | ||
| rot: float |
There was a problem hiding this comment.
I suggest adding a comment that these are all in degrees.
| import lsst.geom | ||
|
|
||
|
|
||
| @dataclass(frozen=True) |
There was a problem hiding this comment.
Please add a comment warning that Visit's members should be builtins, and must be both hashable and JSON-persistable. Otherwise we'll just make the same mistake again.
ebellm
force-pushed
the
tickets/DM-34132
branch
from
c99c9cb to
a060fb6
Compare
ebellm
force-pushed
the
tickets/DM-34132
branch
from
a060fb6 to
9171e72
Compare
kfindeisen
approved these changes
Mar 21, 2022
|
@kfindeisen, can you take another look? I confirmed that upload.py is working, with HSC as well as a simulated instrument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.