DM-47387: Prompt Processing can't handle blank filters in nextVisit message #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ButlerCollections.defaults is only specced as a sequence, and all three contexts require a specific class (list or set), the converting constructor calls can't be removed.
The SAL spec allows filters to be the empty string to indicate that the script did not specify a filter. If such a message is received, do not constrain dataset queries by filter. For this option to be useful, the dataset cache must be large enough to store one calib per filter. The unit tests' default cache has been expanded accordingly.
kfindeisen
force-pushed
the
tickets/DM-47387
branch
from
829eca8 to
0f2acaa
Compare
Visits with unspecified filter may download calibs or templates for all filters. Such a download must not overflow the local cache by itself. However, since image-type calibs and coadds are among the largest input datasets, we must be careful not to expand the cache more than necessary.
hsinfang
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some special-case handling for nextVisit messages with empty filters (as is common for engineering data). The cases are handled at a fairly low level (
_export_calibsand_export_skymap_and_templates) because I don't see an obvious way to unify what's essentially a query tweak. This may need to be revisited on #204, which reworks how the preload queries are executed.