-
Notifications
You must be signed in to change notification settings - Fork 0
DM-35052: Fix single visit restriction for Prompt Processing #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36f25cf
to
9f911c6
Compare
1b09d34
to
894d2d7
Compare
a8fb133
to
15ff5d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement. My only real concern is about the "metadata in paths"; a unittest there would help.
Using paths for metadata always makes me nervous, but I guess we have a closed ecosystem here so it should be fine.
"y": "phot_g_mean", | ||
"VR": "phot_g_mean"} | ||
config.astromRefObjLoader.anyFilterMapsToThis = "phot_g_mean" | ||
config.astromRefObjLoader.filterMap = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines are technically not necessary, since DM-27013 is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that, but for configuration that depends on the input data, I prefer to be explicit instead of trusting that the defaults match up with I really need.
Note that previously, we were using the filename for metadata, which is even harder to control. |
This allows more flexibility in the raw filename, removing a constraint on what naming convention the summit team can choose.
The increase in the raw dataset size makes it unnecessary, and it complicates ID management.
ef397ab
to
63b7e69
Compare
This PR fixes some bit rot in the prototype, adds support for a larger test dataset (up to 4 visits), and removes single-visit-only code from
upload.py
and therun_pipeline
method.It is not yet possible to handle multiple visits with the prototype, because the Butler management needs to be made more flexible first (DM-35051).