DM-35052: Fix single visit restriction for Prompt Processing #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-35052
branch
from
36f25cf to
9f911c6
Compare
kfindeisen
force-pushed
the
tickets/DM-35052
branch
4 times, most recently
from
1b09d34 to
894d2d7
Compare
kfindeisen
force-pushed
the
tickets/DM-35052
branch
from
a8fb133 to
15ff5d3
Compare
parejkoj
approved these changes
Jul 15, 2022
| "y": "phot_g_mean", | ||
| "VR": "phot_g_mean"} | ||
| config.astromRefObjLoader.anyFilterMapsToThis = "phot_g_mean" | ||
| config.astromRefObjLoader.filterMap = {} |
There was a problem hiding this comment.
These two lines are technically not necessary, since DM-27013 is done.
There was a problem hiding this comment.
I didn't know that, but for configuration that depends on the input data, I prefer to be explicit instead of trusting that the defaults match up with I really need.
Note that previously, we were using the filename for metadata, which is even harder to control. |
This allows more flexibility in the raw filename, removing a constraint on what naming convention the summit team can choose.
The increase in the raw dataset size makes it unnecessary, and it complicates ID management.
kfindeisen
force-pushed
the
tickets/DM-35052
branch
from
ef397ab to
63b7e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bit rot in the prototype, adds support for a larger test dataset (up to 4 visits), and removes single-visit-only code from
upload.pyand therun_pipelinemethod.It is not yet possible to handle multiple visits with the prototype, because the Butler management needs to be made more flexible first (DM-35051).