DM-47620 Add single-frame SS association to SingleFrame.yaml #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerenjie
force-pushed
the
tickets/DM-47620
branch
from
6e44fff to
f698624
Compare
Gerenjie
force-pushed
the
tickets/DM-47620
branch
from
0cd130b to
c2b7008
Compare
mrawls
approved these changes
Nov 20, 2024
mrawls
reviewed
Nov 20, 2024
Gerenjie
force-pushed
the
tickets/DM-47620
branch
from
c2b7008 to
e780c39
Compare
|
FTR, I asked @Gerenjie not to merge this along with the Science Pipelines changes, because we can't test until we have a daily and this change breaks compatibility with previous Science Pipelines builds. I'll try to do an a posteriori test tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding of why I was instructed to make these changes in the particular structure I did:
As-is, SingleFrame.yaml exists in prompt_processing but nowhere else. We want a system in which ap_pipe (and ci_pipe and drp_pipe) sit on top of everything else and describe pipeline functionality via yamls. All prompt_processing pipeline yamls should reference and modify counterparts in ap_pipe. At the moment, SingleFrame.yaml is a standalone prompt_processing pipeline, so in addition to adding single-frame association to it, I was asked to also move it into ap_pipe in a traditional LSSTComCam -> _ingredients reference chain.