DM-47829: Prompt Processing never retries if exposure does not generate visits #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-47829
branch
from
8190c34 to
7e7eed3
Compare
kfindeisen
force-pushed
the
tickets/DM-47829
branch
from
7e7eed3 to
16cc418
Compare
isullivan
approved these changes
Nov 28, 2024
This pipeline makes it easier to test edge cases associated with ISR-cal and similar pipelines.
RuntimeError is also raised for input errors (e.g., invalid data IDs), so catching it masks problems with the test itself.
fake_file_data returns a data ID, but most tests don't actually use it. Leave it unassigned.
No visits naturally occur when processing engineering data, such as daytime checkout.
kfindeisen
force-pushed
the
tickets/DM-47829
branch
from
16cc418 to
189a4eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that flags failed engineering runs as "potentially modifying" the APDB.