Skip to content

Conversation

kfindeisen
Copy link
Member

This PR adds a badge to the readme, and fixes the Release CI workflow's trigger conditions to ignore merges to main (a job condition prevents these from actually running, but they still count as execution history).

@kfindeisen kfindeisen requested a review from erinleighh April 7, 2025 21:18
Copy link
Contributor

@erinleighh erinleighh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

README.rst Outdated
.. image:: https://github.com/lsst-dm/prompt_processing/actions/workflows/ci-release.yaml/badge.svg?event=push
:target: https://github.com/lsst-dm/prompt_processing/actions/workflows/ci-release.yaml

.. Can't think of any useful alt text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that the alt text can't be auto generated based on what the badge says.

Perhaps this for alt text: Release CI Build Status Badge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that that's exactly the sort of thing that isn't helpful in e.g. a screen reader. 😕 Maybe just "Release CI Build Status", which is at least a good name for the hyperlink?

The badge can't be filtered to only builds triggered by a tag, but it
at least ignores any PR builds.
The branches-ignore filter causes the workflow to trigger on (some)
branches, when a pure tags filter would not.
@kfindeisen kfindeisen force-pushed the u/kfindeisen/ci-badge branch from 5df5789 to 7631957 Compare April 8, 2025 21:39
@kfindeisen kfindeisen merged commit abe0c17 into main Apr 8, 2025
10 checks passed
@kfindeisen kfindeisen deleted the u/kfindeisen/ci-badge branch April 8, 2025 21:41
@kfindeisen kfindeisen added the ignore-for-release Does not affect the containers (changes only to docs, the uploaders, and/or unit tests) label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Does not affect the containers (changes only to docs, the uploaders, and/or unit tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants