DM-49966: Support new-style coadds as Prompt Processing templates #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Apr 9, 2025
This is a standardized dataset type name that will be used going forward. However, for now Prompt Processing must support both on a pipeline-by-pipeline basis. template_coadd is not yet covered by unit tests, because we don't have any examples that can go into the local repo. We may need to switch instruments to support this case.
kfindeisen
force-pushed
the
tickets/DM-49966
branch
from
489fd79 to
438b63b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds forward-compatibility with the
template_coadddataset type mandated by RFC-1049. It keeps compatibility withdeepCoadd/goodSeeingCoadduntil those fall out of use.