Skip to content

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Apr 18, 2025

This PR turns off an option that gives the following error: ValueError: Cannot apply quadratic crosstalk correction with doBootstrap=True.

This option is invalid with the latest obs_lsst.
@kfindeisen kfindeisen changed the title Turn off bootstrapping in Isr-cal.yaml. Turn off bootstrapping in Isr-cal.yaml Apr 18, 2025
@kfindeisen kfindeisen changed the title Turn off bootstrapping in Isr-cal.yaml Reconfigure ISR-Cal for latest obs_lsst Apr 18, 2025
@kfindeisen kfindeisen requested a review from hsinfang April 18, 2025 23:56
@kfindeisen kfindeisen force-pushed the u/kfindeisen/bootstrap-fix branch from 16c5f28 to d970406 Compare April 19, 2025 00:21
Copy link
Collaborator

@hsinfang hsinfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a quick fix to the issue. I think we will want to think about this (i.e. get pipelines folks to tell us more) and possibly pick a more appropriate fix. But good to merge so we have a release tonight.

@kfindeisen kfindeisen merged commit d993bd3 into main Apr 19, 2025
23 of 26 checks passed
@kfindeisen kfindeisen deleted the u/kfindeisen/bootstrap-fix branch April 19, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants