DM-36999: Complete integration test at USDF #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a limit of the boto3 API; see #35 for discussion.
kfindeisen
force-pushed
the
tickts/DM-36999
branch
from
cc6c4b5 to
3b6e5a5
Compare
The Contents field does not exist if no files are found, so the old code would crash with a KeyError.
kfindeisen
force-pushed
the
tickts/DM-36999
branch
from
0e398a2 to
8a58099
Compare
The topic is still hard-coded into the file, until we can decide how we want topics to be organized.
|
Closed due to branch rename; reopened as #38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy PR to allow for test container builds.