DM-33936: Create GHAs to build containers and run unit tests. #4
Conversation
.github/workflows/build-service.yml
Outdated
| branches: | ||
| - main | ||
| paths: | ||
| - '.github/workflows/build-service.yml' | ||
| - 'python/activator/**' | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflows/build-service.yml' | ||
| - 'python/activator/**' | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Why have the build be on PR, but not on push? This will make it harder to test changes to the activator code (the main reason I can imagine wanting branch builds in the first place).
There was a problem hiding this comment.
It's on any update to the PR, including pushes to the branch that is being PRed. Pushes to non-PR branches are more likely to be in-development and not actually ready for testing.
There was a problem hiding this comment.
I don't follow. Isn't "in development" exactly when you want to test, while a PR means it's ready for use?
There was a problem hiding this comment.
I typically use non-PR (or draft PR) branches as places to save random commits that may not actually function, creating the PR only when I expect it to actually work.
But the workflows as written allow you to manually trigger a build on any branch (or ref) you'd like: Actions tab, "Select workflow" button, "Run workflow" button, enter branch/tag/ref.
|
Urgh. Except that we've never pushed a "latest" to GitHub. Let me see if I can fix that... |
Credentials are needed to pull the container for testing.
2 participants
No description provided.