DM-37068: Clear out conflicting datasets before prompt processing runs #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-37068
branch
3 times, most recently
from
ac1b0c3 to
dfe302a
Compare
Caching problems only appeared on Google. While future architectural changes (i.e., using multiple Butlers for the same repo) might bring back caching problems, it's better to try to write such a test when we can confirm it reproduces the problem.
This is a workaround for not being able to handle pre-existing datasets that don't depend on exposure-detector in a coherent fashion. Removing non-detector datasets allows the same run to be reused without collisions either in the local or central repos.
This change makes it safe to have a single global run for the entire MiddlewareInterface class.
kfindeisen
force-pushed
the
tickets/DM-37068
branch
from
dfe302a to
1e3849f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code for removing shared (usually init-output) datasets from an output run, making it possible to reuse runs for multiple groups and detectors. Actually implementing reuse is deferred to DM-36586.
The deletion is a stopgap until DM-36162 gives us better tools for handling preexisting or conflicting datasets, so the new code is all written on the assumption that it will be removed later.