Skip to content

Conversation

hsinfang
Copy link
Collaborator

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor comments.



def main():
logging.basicConfig(level=logging.DEBUG, stream=sys.stdout)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be INFO instead? I'm a bit worried that making the default logger DEBUG will lead to far too much information...


"""Export goodSeeingCoadd from a collection and make an export file
for importing those data to a central prompt processing repository.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document that this takes all coadds from the target collection, without selecting them in any way?

@hsinfang hsinfang merged commit 2ffc108 into main Feb 15, 2023
@hsinfang hsinfang deleted the tickets/DM-37751 branch February 15, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants