DM-37745: Prompt processing preload fails silently if central repo doesn't have prerequisites #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new name, _filter_datasets, does not carry the previous connotation of being a query, allowing future changes to impose behavior that is not query-like but is needed by MiddlewareInterface.
We need to distinguish the case where the source repo has datasets but they're redundant with the destination (nothing to do) from the case where the datasets are absent entirely (impending pipeline failure). The _filter_datasets function now checks if the source query is empty before filtering. Because of the behavior change, the unit tests of prep_butler had to be amended to avoid raising on missing templates.
isullivan
approved these changes
Mar 3, 2023
kfindeisen
force-pushed
the
tickets/DM-37745
branch
from
e2ebeef to
55d5270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old
_query_missing_datasetswith a new function,_filter_datasets, that raises if the source repository does not have anything matching the query. This behavior is needed in all contexts whereMiddlewareInterfacequeries both the central and local repositories, though it's inappropriate for a general-purpose query.