DM-38405: Update the nextVisit events produced by the tester upload scripts #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-38405
branch
2 times, most recently
from
c069a86 to
4442444
Compare
kfindeisen
reviewed
Apr 13, 2023
| dome: Dome | ||
| duration: float # script execution, not exposure | ||
| nimages: int # number of snaps expected, 0 if unknown | ||
| survey: str # survey name |
There was a problem hiding this comment.
Can you also update the documentation of filters to say that these filter names are in the Middleware format, including ~ for composite filters? Following up on https://lsstc.slack.com/archives/C0345PUU4N9/p1679429952829539.
ebellm
approved these changes
Apr 13, 2023
hsinfang
force-pushed
the
tickets/DM-38405
branch
from
4442444 to
2b19aa5
Compare
This is a preparation for the upcoming change that we will start to differentiate detector-level Visit versus visit-level Visit.
This changes the schema to be the same as messages from the summit. It is an interim commit to review before removing kakfa producer.
This cleans up codes that are no longer used. next_visit messages are now sent to Sasquatch via the HTTP-based Confluent REST proxy.
As the fan-out service is standing up, the next visit messages sent by the upload tester scripts should be at the visit level as those from the summit, and they are to be consumed by the fan-out service. A SummitVisit class is added for the summit-style messages, which have some extra private_ fields.
Currently the filter naming format in the summit messages are differnt from the format in the Middleware, but will be fixed in CAP-967. Even if the summit format is different, the fan-out service fixes it to be in the Middleware format.
hsinfang
force-pushed
the
tickets/DM-38405
branch
from
2b19aa5 to
94669f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.