DM-39395: Use day_obs in run names #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The day_obs is defined so that it will be the same for any observing run, regardless of when in the night it is created. It's also frequently used to identify exposures, so it's less confusing if the run name matches it.
kfindeisen
added a commit
that referenced
this pull request
Jun 16, 2023
The time zone used to datestamp runs was changed in #68, but the tests were never updated to match. This caused failures when running the tests between 0:00 and 12:00 UTC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the naming convention for output runs so that all products of the same pipeline and the same night should go into the same run.