DM-37253: Make Prompt Processing service configurable #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class will encapsulate pipeline selection configuration and transfer the information between the activator and MiddlewareInterface. The current class is a stub with no functionality.
The initial implementation is a copy of MiddlewareInterface._get_pipeline_file.
This change completes the transfer of existing pipeline-selection functionality from MiddlewareInterface to PipelinesConfig.
hsinfang
approved these changes
Jun 15, 2023
| """ | ||
| # Use regex instead of str.split, in case keys or values also have spaces. | ||
| node = re.compile(r'\s*\(survey="(?P<survey>[\w\s]+)"\)=' | ||
| r'(?P<filename>[-\w./${} ]*[-\w./${}])(?:\s+|$)') |
There was a problem hiding this comment.
Probably just a matter of taste. Would r'(?P<filename>[^=,]*[^=, ])(?:\s+|$)')
be slightly easier to read and still correct?
There was a problem hiding this comment.
I had that before, actually, but then got worried that that might match some unexpected (and possibly malicious) string. I figured it's best to err on the side of being too restrictive.
I agree that ^=, would be easier to read.
kfindeisen
force-pushed
the
tickets/DM-37253
branch
from
7db0070 to
14f75ad
Compare
The input only supports simple survey-pipeline mappings for now, but is designed with future selection criteria in mind.
The pipeline was only used by test_middleware_interface.py, but had to go into `pipelines/` because that location was assumed by the application code.
kfindeisen
force-pushed
the
tickets/DM-37253
branch
from
14f75ad to
247e890
Compare
The survey field is not always populated for test data.
All but the shortest config strings provided through environment variables are likely to be multiline, so this case must be supported.
kfindeisen
force-pushed
the
tickets/DM-37253
branch
from
247e890 to
2f33a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pipeline configuration variable (
PIPELINES_CONFIG) to the service setup, which maps surveys to pipelines. This allows the target pipeline(s) to be controlled fromprompt-proto-service.yamlinstead of being hardcoded intoMiddlewareInterface.py.