Skip to content

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Aug 9, 2023

This PR adds a private_sndStamp member to FannedOutVisit, and modifies the uploaders to populate it based on the exposure time. This is a breaking change to FannedOutVisit, and must be merged alongside lsst-dm/next_visit_fan_out#1.

This function converts the day_obs code (which is what Middleware uses
to determine calib validity) to a Unix timestamp (which is what the
SAL messages report).
This field lets the activator know the age of the message without
reference to the event framework, and allows the uploaders to use
appropriate timestamps for their simulated observations.
@kfindeisen kfindeisen marked this pull request as ready for review August 15, 2023 22:50
@kfindeisen kfindeisen requested a review from dspeck1 August 15, 2023 22:50
Copy link
Collaborator

@dspeck1 dspeck1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kfindeisen kfindeisen merged commit 9b47f4a into main Aug 16, 2023
@kfindeisen kfindeisen deleted the tickets/DM-40296 branch August 16, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants