-
Notifications
You must be signed in to change notification settings - Fork 0
DM-37387: A tester script using LATISS data in /repo/embargo #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51a314c
to
2202fea
Compare
An obvious problem here is that some export scripts are somewhat similar but I haven't bothered to consolidate them. In particular this new script and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial script looks very clean and clear. However, I don't think I understand the --target-repo
argument or the code that depends on it. Could you please clarify how it works, and when the caller might opt not to use it?
This script makes an |
4c834ca
to
8651555
Compare
@kfindeisen may you please take another look? Thanks to your feedbacks I think the script looks better now. It still assumes some peculiarities of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Minor comments only.
0e92228
to
07c3347
Compare
This is used to export templates, refcats, skymap, and calib datasets from /repo/embargo to s3://rubin:rubin-pp-users/central_repo/. This also exports the LATISS/calib and LATISS/templates chains from /repo/embargo.
07c3347
to
33d8cfd
Compare
If no target repo is given, make a temporary empty butler repo, so all selected datasets would be exported.
33d8cfd
to
f332839
Compare
A first part of this ticket to get test data into
s3://rubin:rubin-pp-users/central_repo