DM-40163: Rework dataset transfer code in MiddlewareInterface #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that all three _export_* methods export only datasets, making it easier to treat them identically.
This change makes all the `_export_*` methods agnostic to how we actually do the export. Their responsibility is now focused exclusively on identifying the target datasets.
This change allows collections to be exported independently from their datasets (export/import ties everything to datasets). Calibration collections, however, need special handling for their associations under the new system.
By using a combination of transfer_from, registerCollection, and certify, we can avoid needing to know where datasets are stored, and therefore using the deprecated Butler.datastore.root.
timj
approved these changes
Sep 26, 2023
Actually, it seems about the same: the integration test for this ticket had downloads of <2.4-3.8 s for |
By using a combination of transfer_from and syncDimensionData, we can avoid needing to know where datasets are stored, and therefore using the deprecated Butler.datastore.root.
kfindeisen
force-pushed
the
tickets/DM-40163
branch
from
631b8ba to
ac32674
Compare
|
The speed up mainly comes when you have large numbers of datasets. Switching execution butler to transfer_from from export/import made a huge difference for 100k datasets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the export/import idiom from MiddlewareInterface. The old idiom needed to use the deprecated
butler.datastore.rootto anchor relative paths, and there's no guarantee that the central repo won't have its datasets split among multiple stores.