DM-41084: AttributeError: '_thread._local' object has no attribute 'context' #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-41084
branch
from
bd6db52 to
a65f1c3
Compare
ktlim
approved these changes
Oct 13, 2023
Putting the context in a property lets most of the factory's code be agnostic to the use of thread-local storage, and also gives us more control over how the context is initialized for each thread.
Since threading.local objects don't provide a happens-before guarantee for their initial state, they must be initialized in the thread that will use them. Lazy initialization on first use provides an easy way to do this.
kfindeisen
force-pushed
the
tickets/DM-41084
branch
from
a65f1c3 to
c3dc43a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defers initialization of
RecordFactoryContextAdapter._store.contextto ensure that each thread sees the correct initial state (an empty mapping). This prevents a bug where attempts to log from any thread other than the main one raised anAttributeError.