DM-41658: Prompt Processing can't configure surveys with "-" #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently encountered a survey name with hyphens; this patch also preemptively allows other characters. The only characters that are still forbidden are " (the delimiter), = (which is generally forbidden for ease of parsing), and newline (no legitimate use, possibly a sign of shady business).
Such newlines are not expected to be legitimate, and could indicate something fishy going on. However, we want to allow newlines *between* paths, as this is the most convenient way of formatting pipeline lists.
This debug-level log ensures we can always identify exactly what a given pod received, in case it doesn't match (or is too hard to correlate with) the output of fan-out.
|
Added one last-minute commit to log incoming |
hsinfang
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the pipeline config parsing more flexible regarding survey names, now allowing any character that isn't clearly problematic.