DM-53499: Use stellar motion catalog to correct positions #447
Conversation
cmsaunders
changed the title
| dimensions=("instrument", "skymap", "tract", "physical_filter"), | ||
| multiple=True, | ||
| astrometricCorrectionCatalog = ct.Input( | ||
| doc="Table of associated sources", |
There was a problem hiding this comment.
Could this doc be clearer? I'm not entirely certain what associated sources means.
There was a problem hiding this comment.
This is actually a copy-paste error. I changed it to "Catalog with proper motion and parallax information."
| # in the join and avoid sorting. | ||
| dataWithMJD.sort("__index__") | ||
| medianMJD = astropy.time.Time(np.median(mjds), format="mjd", scale="tai") | ||
| mjds = visitTable.loc[dataWithPM["visit"]]["expMidptMJD"] |
There was a problem hiding this comment.
Probably outside the scope of this ticket but can we one day get the visitTable to be astropy and remove the uses of pandas.
There was a problem hiding this comment.
I would do it if I had finished 12 hours earlier...I think we can get rid of the rest of the pandas pretty easily on another ticket now though.
There was a problem hiding this comment.
I know that feeling, a future ticket would be great, thank you.
| "pmRA": "raPM", | ||
| "pmDec": "decPM", | ||
| "parallax": "parallax", | ||
| "isolated_star_id": "isolated_star_id", |
There was a problem hiding this comment.
Does this one need to be snake case when all of the others are camel case? Also above I think.
There was a problem hiding this comment.
Both the left and right hand sides have to match what is in existing tables.
| Catalog containing the epoch for the visit corresponding to the | ||
| isolatedSources. | ||
| astrometricCorrectionCatalog : `pd.DataFrame` | ||
| astrometricCorrectionCatalog : `astropy.table.Table` |
cmsaunders
force-pushed
the
tickets/DM-53499
branch
from
faa688d to
153a4ab
Compare
No description provided.