DM-52724: Build cell-based coadds with edges #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 20, 2025
|
|
||
| overlaps_center = detector_map[geom.Point2I(bbox.getCenter())] == ccd_row["ccd"] | ||
| if overlaps_center: | ||
| if not ccd_row.contains(cell_centers_sky[cellInfo.index]): # DROP THIS AFTER TESTING!!! |
arunkannawadi
commented
Oct 20, 2025
| psf_eval_point = geom.Point2D(inner_bbox.getCenter()) | ||
| psf_shape = warp.psf.computeShape(psf_eval_point) | ||
| psf_shape_flag = False | ||
| except (SinglePolygonException, InvalidPsfError): |
Member
Author
There was a problem hiding this comment.
I don't see a scenario why SinglePolygonException should be raised, since the input visit has passed other cuts, but it still does happen. The psf_shape_flag is also used to mean that we set a nominal value of ixx=iyy=1 and ixy=0 but that means nothing.
arunkannawadi
commented
Oct 20, 2025
| psf_shape = warp.psf.computeShape(psf_eval_point) | ||
| psf_shape_flag = False | ||
| except (SinglePolygonException, InvalidPsfError): | ||
| self.log.warning("Blah") |
Member
Author
There was a problem hiding this comment.
I'll put in a more informative log message here!
arunkannawadi
force-pushed
the
tickets/DM-52724
branch
5 times, most recently
from
0526c1d to
b6664cc
Compare
arunkannawadi
force-pushed
the
tickets/DM-52724
branch
from
b6664cc to
a3a9987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.