DM-53063: Add preliminary_mask input connection to reprocessVisitImage #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-53063
branch
from
794bc01 to
59b3349
Compare
TallJimbo
approved these changes
Oct 28, 2025
| if mp not in exposure.mask.getMaskPlaneDict().keys(): | ||
| exposure.mask.addMaskPlane(mp) | ||
| bitMask = mask.getPlaneBitMask(mp) | ||
| exposure.mask.array |= ((mask.array & bitMask) > 0) * bitMask |
There was a problem hiding this comment.
You can transfer all of the mask planes at once:
bitMask = mask.getPlaneBitMask(self.config.copyMaskPlanes)
exposure.mask.array |= mask.array & bitMask
I don't think you need the loop to add mask planes, either; just reading the new mask will add them to the global plane dict if they weren't there already.
There was a problem hiding this comment.
I changed this to remove part of the loop, and added a unit test to verify the behavior.
isullivan
force-pushed
the
tickets/DM-53063
branch
from
59b3349 to
3ec3b59
Compare
isullivan
force-pushed
the
tickets/DM-53063
branch
from
3ec3b59 to
d69952f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preliminary_mask is written by
calibrateImageand persisted as a separate dataset so that the fullpreliminary_visit_imagedoes not need to be saved until step 4 of DRP processing.