DM-53339: Prevent memory spike when loading reference catalog #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-53339
branch
2 times, most recently
from
2d18166 to
973673b
Compare
erykoff
approved these changes
Nov 20, 2025
Contributor
erykoff
left a comment
erykoff
left a comment
There was a problem hiding this comment.
A couple of small comments
| center, radius, self.config.referenceFilter, epoch=formattedEpoch | ||
| ) | ||
| except RuntimeError: | ||
| self.log.debug("Reference catalog shard %d is empty: ", dataId["htm7"]) |
Contributor
There was a problem hiding this comment.
I think this could also happen if the butler gives extra shards that don't overlap your circle. Which is fine!
Collaborator
Author
There was a problem hiding this comment.
I'll edit the message to be more generic.
| "pm_ra_pm_dec_Cov", | ||
| "pm_ra_parallax_Cov", | ||
| "pm_dec_parallax_Cov", | ||
| ] |
Contributor
There was a problem hiding this comment.
Were these column names always hard-coded?
Contributor
There was a problem hiding this comment.
Or are they supposed to come from a config?
Collaborator
Author
There was a problem hiding this comment.
No, they're set by the meas_algorithms ConvertRefCatManager. That's what the version is for.
cmsaunders
force-pushed
the
tickets/DM-53339
branch
from
973673b to
19f037a
Compare
cmsaunders
force-pushed
the
tickets/DM-53339
branch
from
19f037a to
dec6e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.