DM-52921: Add errors to be imported with __all__ #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-52921
branch
from
1bca474 to
8685151
Compare
fred3m
changed the title
leeskelvin
reviewed
Oct 29, 2025
| @property | ||
| def metadata(self): | ||
| for key, value in self._metadata.items(): | ||
| if not (isinstance(value, int) or isinstance(value, float) or isinstance(value, str)): |
There was a problem hiding this comment.
Is this not equivalent to:
if not isinstance(value, (int, float, str)):
?
There was a problem hiding this comment.
Oh, yes it is. I literally just copied this whole class from https://github.com/lsst/meas_algorithms/blob/main/python/lsst/meas/algorithms/scaleVariance.py#L32-L59 and didn't even think about that.
leeskelvin
approved these changes
Oct 29, 2025
fred3m
force-pushed
the
tickets/DM-52921
branch
from
8685151 to
f45c6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.