DM-53153: Add safeguards on image statistics based scalings in detectCoaddPeaks #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctslater
approved these changes
Nov 12, 2025
| and threshResults.multiplicative < self.config.minThresholdScaleFactor): | ||
| self.log.warning("Measured threshold scaling factor (%.2f) is outside [min, max] " | ||
| "bounds [%.2f, %.2f]. Setting lower limit to %.2f.", | ||
| threshResults.multiplicative, self.config.minThresholdScaleFacto, |
Member
There was a problem hiding this comment.
typo, minThresholdScaleFacto. Makes me worried this code path isn't tested.
Contributor
Author
There was a problem hiding this comment.
Oooh, good catch. Fixed and added more test coverage.
| if (self.config.minThresholdScaleFactor | ||
| and threshResults.multiplicative < self.config.minThresholdScaleFactor): | ||
| self.log.warning("Measured threshold scaling factor (%.2f) is outside [min, max] " | ||
| "bounds [%.2f, %.2f]. Setting lower limit to %.2f.", |
Member
There was a problem hiding this comment.
Setting the scale factor to lower limit, not setting the lower limit. Same comment on other messages.
| if self.config.doBrightPrelimDetection: | ||
| brightDetectedMask = self._computeBrightDetectionMask(maskedImage, convolveResults) | ||
| else: | ||
| prelim = None |
Member
There was a problem hiding this comment.
preliminary what?
Are you ok with results.prelim being None? If nothing uses it downstream, might as well remove it.
Contributor
Author
There was a problem hiding this comment.
I'm too nervous to do this just in case somewhere/somehow expects the parameter to exist...
Member
There was a problem hiding this comment.
I'm ok with "not on this ticket on a wednesday".
Also add configurable upper and lower limits to the value the scaling can take.
laurenam
force-pushed
the
tickets/DM-53153
branch
from
abe085a to
167514a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.