DM-53311: LSSTCam DRP error in detectCoaddPeaks: "Exception ZeroDivisionError: division by zero" #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctslater
approved these changes
Nov 19, 2025
| if factor > 2.0: | ||
| if growOverride is None: | ||
| growOverride = 0.75*self.config.nSigmaToGrow | ||
| if results.numPos == 0: |
Member
There was a problem hiding this comment.
The catch is fine here but I'm pretty worried about this creating an infinite loop, e.g. if we accidentally get an image of the inside of the dome and no stars. Is there a good way to guarantee this doesn't get stuck?
Secondarily, maybe if the number of footprints is extremely low but not zero, we're better off just punting rather than trying to chase it by adjusting the detection threshold factor? (like, if we have two footprints, is that image really salvageable?)
Contributor
Author
There was a problem hiding this comment.
As you point out in the ticket, I'll change this to just bail out instead of trying to adapt to what is likely to be a lost cause...
laurenam
force-pushed
the
tickets/DM-53311
branch
from
1d3867e to
45c5b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.